Skip to content

Conversation

youssefea
Copy link
Contributor

What changed? Why?

Adding a guide for developers using the new Base <> Solana bridge

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 2, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for kmk142789 @ 2025-10-06 14:32:37 UTC
User must have write permissions to review

## How it works

### On Base
The Base bridge contract locks or burns tokens when sending messages to Solana,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say "locks or burns" and "mints or unlocks"

Is it truly either? Or are we using these words as synonyms? If its just synonyms we should pick a single word. I think "lock" and "unlock" are the most immediately understood by the widest audience

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's either, and it depends if the token is native to base (locks) or native to solana (burns) - I'll clarify it though, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added callouts to clarify

Copy link
Collaborator

@ericbrown99 ericbrown99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A broader preference of mine would be to move the "how it works" section below the implementation sections. And then in the implementation sections, we could have an internal link to the how it works section, something like "Read here to learn more about how the solana <>Base bridge works"
This focuses the doc on implementation and our general goal of shortening time to implementation, while still ensuring that the way the bridge works is documented

@youssefea
Copy link
Contributor Author

A broader preference of mine would be to move the "how it works" section below the implementation sections. And then in the implementation sections, we could have an internal link to the how it works section, something like "Read here to learn more about how the solana <>Base bridge works" This focuses the doc on implementation and our general goal of shortening time to implementation, while still ensuring that the way the bridge works is documented

I would generally agree once we have clearer and easier paths towards integration (SDK), but I think in this case, it is unfortunately hard to start implementing without a basic understanding of how the bridge works - as it's a still a bare-bone smart contracts protocol and any developer would have to interact with the contract directly

@youssefea youssefea merged commit d0c2031 into master Oct 9, 2025
8 checks passed
@youssefea youssefea deleted the base-solana-bridge branch October 9, 2025 18:13
@youssefea youssefea restored the base-solana-bridge branch October 9, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants